Fix Boost.Bind global placeholder deprecation warning - #21
Merged
Conversation
<boost/bind.hpp> injects _1, _2, ... into the global namespace, which Boost 1.73+ deprecates with a #pragma message. Switch to the non-polluting header <boost/bind/bind.hpp>; no using-declaration needed since the call site uses a plain function pointer with no placeholders. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Boost.Bind include in hybmain.cpp to avoid the Boost 1.73+ deprecation warning caused by boost/bind.hpp injecting _1, _2, … into the global namespace, while keeping existing boost::bind usage intact.
Changes:
- Replace
#include <boost/bind.hpp>with#include <boost/bind/bind.hpp>inhybmain.cpp. - Preserve the existing
boost::bind(&stop_callback, ...)call site without introducingboost::placeholders(none are used).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include <boost/bind.hpp>with#include <boost/bind/bind.hpp>inhybmain.cppboost/bind.hppinjects_1,_2, … into the global namespace, which Boost 1.73+ warns about at compile timeusing namespace boost::placeholdersneeded since the only call site (s.run(boost::bind(&stop_callback, ...))) uses a plain function pointer with no placeholdersTest plan
#pragma messagedeprecation note no longer appearsalps_cthyblinks and runs as before🤖 Generated with Claude Code